New AeroDynInflow module with c-bindings interface #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ADIWSolve in ADI_CalcOutput)
This is a very rough start -- it is a placeholder for something that compiles and doesn't segfault. It is merely a starting point.
If the last line does not have a carriage return, the file may be passed with no NULL at the end of the last line. If this happens and the last line starts with "END", the routine for finding the outlist may overstep the end of hte FileInfoType and read garbage (or segfault) -- at the very least give nasty errors from whatever code called it to parse the FileInfoType into the file structure. This fixes this issue.
Compare BldPtMotionMesh with AD_Blade vtk outputs to see that things now align
Kind of rough python code that looks pretty ugly
ebranlard
changed the title
ebranlard
force-pushed
the
f/adi_c_binding
branch
from
57433b1
to
aeb0570
Compare
…with really small motion
andrew-platt
force-pushed
the
f/adi_c_binding
branch
from
5653f4e
to
061d13c
Compare
ebranlard
approved these changes
Oct 24, 2022
andrew-platt
added a commit
to OpenFAST/r-test
that referenced
this pull request
Oct 25, 2022
This is a test case for testing the ADI interface through python (AeroDyn + InflowWind). This goes along with OpenFAST/openfast#1110 The mesh motion from the 5MW_OC4Semi_WSt_WavesWN case with a rigid turbine is used as inputs to the python driver code, and passed through to the ADI library (the results are very slightly different due to the rigid turbine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ready for merging
Feature or improvement description
This PR introduces a new library version of the AeroDyn and InflowWind modules together (called
AeroDyn_Inflow) with a c-bindings interface for calling from other codes. Included with this PR:AeroDyn_Inflow.f90that wraps both AeroDyn15 and InflowWind together for the AeroDyn15 driver, and for this library interface.AD_WrVTKadded to AeroDyn_IOAD_NumWindPointsadded to AeroDyn.f90This module interface is compatible with the OWENS vertical axis wind turbine code from Sandia National Labs.
Missing things:
Related issue, if one exists
This is the 4th PR providing a c-bindings interface for a module and follows the same architectural design used in those:
Impacted areas of the software
This does not affect any existing functionality of OpenFAST.
Additional supporting information
This project was funded through SBIR funding from ARPA-E in collaboration with XFlow Energy (https://www.xflowenergy.com/).
Test results, if applicable
Comparison between Python or Julia driver simulations to a fully coupled OpenFAST simulation show good agreement. For the OpenFAST simulation, the tower shadow and tower potential have been turned off (the driver has no knowledge of the tower). Loads along the blade span agree well after an initial difference during startup.
Lift force at 3 blade nodes:
Axial induction at 3 blade nodes:
Tangential induction at 3 blade nodes:
To Do