-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the InflowWind disk averaged velocity calculations #1240
Improvements to the InflowWind disk averaged velocity calculations #1240
Conversation
- added output of hub velocity (at actual hub location) - initialize VFlowAngle to 0 in case it is not listed - close echo file - added `HubVel` output to IfW (also in linearization) - modified `DiskVel` output to IfW (also in linearization) - add routines to calculate rotor-averaged mean velocity, `DiskVel` - ADDed input (HubPosition) and output (DiskVel) values to linearization - added option in driver to convert files to Uniform wind files - add option for horizontal shear in native bladed formats - added `WrUniform` to driver input file - added WriteOutputs to InfowWind for Hub and DiskVel output values
was getting error `Error generating plots: name 'localOutFile' is not defined`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the source code changes in great detail (and don't intend to), but overall this looks good to me. My only real comment is that the conversation focuses on how the calculation of DiskVel is improved, but the PR appears to contain much more than that, including new write outputs and functionality to convert from full-field to uniform wind formats.
Here are some comments about what is in this PR from when I sent you guys this code in July:
|
Thanks @bjonkman! I'll incorporate your comments into the notes. Given the caution on DWM, I'm inclined to add a fatal error if it is chosen. I think this PR will get merged in shortly before the removal of AD14. |
…d changes AD14 and DWM will be deprecated shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a random comment,
I'm wondering why we have both .out and .outb in these cases. (probably a lot more other cases have them). This affects the size of the r-test repository.
I would be in favor of having only .outb (since anyway git cannot keep track of differences of channels because .out files are column by column, not line by line (the transpose of it), and let the python script try to open the .outb file if it exists, otherwise the .out file.
The summary files are also a bit unnecessary.
@ebranlard : I've deleted the .out files in the |
I'll remove them from here as well. |
508fa5e
to
8d9c282
Compare
This PR is ready for merging.
Feature or improvement description
The disk average velocity calculation is now based on multiple points instead of simply the hub center. This provides a more realistic average velocity when there is wind shear. There are also a few updates to the InflowWind outputs and driver.
Limitations:
Related issue, if one exists
N/A
Impacted areas of the software
This changes the disk average velocity used in AeroDyn 14. It will also impact future modules including AeroDisk.
Additional supporting information
The methods for extracting a disk average velocity for AD14 have been used since AD12 and are rather suspect. The calculation was different for each wind type and did not account for searh. For example, the disk average velocity from Uniform Wind files is simply the hub height wind speed, and full field files were simply the advection speed. This was resulting in very different loads from AD14 for the same wind profile stored in different wind file formats.
Test results, if applicable
Four regression tests using AD14 fail as a result of this change and must be updated.
WindType
PlExp