NWTC_IO: nullifying DLL (on restart) if not present when packing #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for fixing this! |
bjonkman
approved these changes
Nov 3, 2022
andrew-platt
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ready to be merged
Feature or improvement description
When doing "restarts" using a checkpoint (I've tested it when using the -VTKLin option), OpenFAST exits with the error that that "the Orca Flex library could not be freed", even though Orca Flex was not used at all before or after the restart.
I'm using Windows, and gfortran 10.3. The check whether a library is freed (in
SysGnuWin) is:(see here)I've added nullifications of the C DLL pointers when "unpacking" a DLL_Type. I think that's a good idea to do so no matter what.
I think it could also be safe to add a initializer for the datatype (here )
@bjonkman let me know your thoughts.
Impacted areas of the software
NWTC_IO
Test results, if applicable
No change, this is a restart, which I'm not sure we are testing.