-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFD coupling to use AD15 mesh only #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed the source code changes (and don't intend to), but I agree with the solution as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code is much cleaner this way.
I suggest to add more details in the description of the datatypes (just so that it's easier to get back to it in the future).
Optionally, maybe we can use InterpArray
to shorten the code and make it more readable.
Some updates from @tonyinme: Overlay of the force and velocity measurement locations. The force positions are shown for 3 timesteps and the velocity positions are shown for one timestep. The latest timestep for force position overlaps with the velocity locations as expected. |
b613b9f
to
ce957fd
Compare
AD14 will be deprecated, so there is no reason to finish linking it to OpFM switch to AD15 for blade and tower properties passed to Init_OpFM fix error handling, cleanup code formating and minor rearrangement
- ActForceMotions and ActForceLoads were unnecessary intermediate meshes - fix bug with no tower nodes from Extern or AD15 - tower base height was not accounted for after removal of ED
…arger than AD15 mesh points
ce957fd
to
afc5cab
Compare
For anyone following this PR, I squashed down the commit history for a cleaner looking merge commit. |
This PR is ready for merging
Feature or improvement description
The OpenFOAM module had been using both the ElastoDyn structural mesh (for loads) and the AeroDyn 15 mesh (for motions). After much in person discussions with @tonyinme, @gantech, @michaelasprague, @jjonkman, and @ebranlard
(see #1232), we settled on using only the AeroDyn 15 mesh.
This also allows BeamDyn to be used with CFD codes.
Related issue, if one exists
Impacted areas of the software
Glue code:
OpenFOAM module:
Additional supporting information
The original problem was a mismatch in location of motion points and force points passed to CFD. The velocity points were taken from the AD15 input mesh (interpolated to finer discretization), but the force points were set based on the ElastoDyn blade mesh (also refined discretization).
This PR is a short term fix for the mesh issue. The long term fix will involve modifications to AD15 and interface changes for SOWFA, NALU-Wind, and AMR-Wind:
Recommend squash merge for cleaner history.
Test results, if applicable
@tonyinme will post relevant info from AMR-Wind tests inline below