[BugFix] Visual Studio only building in Single Precision #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
andrew-platt
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge.
Impacted areas of the software
Visual Studio project files (.vfproj)
Additional supporting information
PR #1453 (to remove quad-precision kinds from OpenFAST) broke the backwards compatibility maintained by PR #524 when the
DOUBLE_PRECISIONdefine check was removed fromSingPrec.f90. The CMake build system uses theDOUBLE_PRECISIONflag to specify whether OpenFAST should be compiled in single or double precision; however, CMake defined theOPENFAST_DOUBLE_PRECISIONmacro to indicate this to the compiler.It was incorrectly assumed that the check for the
DOUBLE_PRECISIONmacro wasn't being used; however, Visual Studio used this macro instead ofOPENFAST_DOUBLE_PRECISION. Therefore, removing this check caused Visual Studio to only generate single precision executables.This pull request changes the Visual Studio project files to define
OPENFAST_DOUBLE_PRECISIONto be consistent with CMake and resolve the issue.