Add Mod_AmbWind=3 regression test to the CI #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
added a commit
that referenced
this pull request
Oct 11, 2023
This isn't a totally necessary commit, but keeps the history a bit more logical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
Adds a regression test for the
Mod_AmbWind = 3option in FAST.Farm. Thanks to @MYMahfouz the example case.Also updates
cmake_minimum_versionto match the main OpenFAST repositoryRelated issue, if one exists
This may have been mentioned in an issue, but I could not find one in a quick search.
Impacted areas of the software
New test case
Additional supporting information
We recommend using the
Mod_AmbWind=3option in FAST.Farm, but have not had an example regression test until now.Companion PR in r-test: OpenFAST/r-test#111
Test results, if applicable