[BugFix] SrvD segfault if lidar used, but no SumPrint #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some a missing if statement to check if the summary file is actually being used. If lidar in InflowWind is in use, then a segfault would occur in ServoDyn if `SumPrint` wass set to false.
deslaughter
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
There was some a missing if statement to check if the summary file is actually being used. If lidar in InflowWind is in use, then a segfault would occur in ServoDyn if
SumPrintwass set to false.Thanks to @Guiiem for tracking down the combination of factors that triggered this bug.
Related issue, if one exists
#1690
Impacted areas of the software
The lidar functionality in InflowWind can now be used with SumPrint in ServoDyn is false.
Additional supporting information
Test results, if applicable
No test results are affected (this obscure combination was not tested).