Merge dev to dev-unstable-pointers #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… typos in comments
The reference frame is now moving. All values from p%GlbRot, p%Glb_crv, and p%GlbPos are now stored as otherstates and get updated at the end of an updatestates routine. Additional logic and data handling was changed within BD: - UpdateStates starts with the initial root position at T, and `q` and `dqdt` are relative to this position/orientation. - once UpdateStates converges, the `q` and `dqdt` states are updated to the root position/orientat at T+dt - Output calculations (mesh and channel outputs) have been modified - Inputs are slightly modified as well During Init, the values in `q` and `dqdt` are updated twice. The first time is relative to the reference frame for the meshes, and the second time for the mesh reference frame + displacements.
may have positions in mesh partially correct. Rotations appear too far though, so something wrong with rotation handling
Still has a free energy problem.
Some minor cleanup to better match parent branch (deleted blank lines, etc)
Readthedocs configuration changes
HD Bug Fix: Fix AddF0 for multiple potential-flow bodies with NBodyMod/=0
Updated the MD registry and types file
- fix file name for AeroDyn_Inflow_Registry.txt in the visual studio project files - also add `SAVE` attribute to avoid compiler warnings
Minor fixes for ADI in Visual Studio project files
VS-build updates for rc-3.5.1 and other minor updates
Release 3.5.1
This is an intermediate branch for resolving merge conflicts.
Some compatibility updates were made in main for deprecation warnings on GH actions
Main (3.5.1) to dev merge
andrew-platt
added
Module: HydroDyn
Module: MoorDyn
FAST.Farm
Feature: MHK
deslaughter
approved these changes
Oct 26, 2023
andrew-platt
merged commit 468ddf2
into
OpenFAST:dev-unstable-pointers
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merging
Feature or improvement description
After release 3.5.1, the
mainbranch (3.5.1) was merged intodevwith PR #1834. This PR propagates those updates to thedev-unstable-pointersbranch.Related issue, if one exists
None
Impacted areas of the software
Minor updates and improvements from the 3.5.1 release including visualization of HydroDyn floating platforms and MoorDyn mooring lines.
Additional supporting information
Test results, if applicable
The
ModAmb_3FAST.Farm case was added in 3.5.1, and is included in this PR.