Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWAE: Mod_AmbWind=3 add error if HR grid not centered on turbine in Y dimension #1963

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

andrew-platt
Copy link
Collaborator

This is ready to merge.

Feature or improvement description
When the boundaries for InflowWind interpolation were tightened to end at the edge of the grid with version 3.5.0, this had the unintended consequence of not allowing a small shift of the turbine from the exact center of the high-resolution grid. Previously extrapolation of the wind data outside the grid in the +/-Y direction of up to one step was permitted which allowed the turbine to be slightly offset for Mod_AmbWind=3 cases. However, this is in direct conflict with our modeling guidance for Mod_AmbWind=3 cases; our guidance indicates the high resolution grid must exactly match the InflowWind grid.

The following diagram illustrates what the issue is:
FF_highResGrid_new_offset
Figure: FAST.Farm high res grid and OpenFAST wind grid (Mod_AmbWind=3) in v3.5.x. This is the case where the grid sizing and spacing for the InflowWind grid and high-res grid are identical, but the turbine is slightly offset. The InflowWind grid is always centered about the turbine and therefore does not line up with the high-resolution grid. This effectively moves points in the high-resolution grid outside the available interpolation boundary for the InflowWind wind field.

So to increase usability, we will leave the stricter boundaries in the InflowWind grid interpolation. To make it possible for an end user to figure out what failed, we add an error message indicating what exactly failed and how to fix it. Example error message:
Screenshot 2024-01-08 at 7 47 25 PM

Related issue, if one exists
#1951
https://forums.nrel.gov/t/gf-wind-array-boundaries-violated-grid-too-small-in-y-direction/6149/5

Impacted areas of the software
FAST.Farm usability is somewhat enhanced for Mod_AmbWind=3 cases.

Additional supporting information
There had been multiple reports of issues with Mod_AmbWind = 3 when a turbine was not aligned exactly with the center of high-resolution grid in the Y direction.

Test results, if applicable
N/A

@andrew-platt andrew-platt self-assigned this Jan 9, 2024
@andrew-platt andrew-platt added this to the v3.5.2 milestone Jan 9, 2024
@andrew-platt andrew-platt mentioned this pull request Jan 9, 2024
19 tasks
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this logic makes sense to me. But I do have a few concerns:

  1. With this change, we wont allow the case where the high-res domain is a subset of the TurbSim domain. I'm not sure the user would ever want to do this, but this functionality was possible before this change.
  2. This change forces wind to always propagate along X. The FAST.Farm documentation also suggests that you could propagate wind along Y (by setting PropagationDir in InflowWind to +/-90deg), although I'm not sure anyone ever does this in practice.
  3. Is there a reason why the Z boundary is not checked in addition to Y?

@andrew-platt
Copy link
Collaborator Author

Good thoughts.

  1. I was somehow thinking a smaller grid wasn't possible. I'll can modify the checks to allow smaller grids.
  2. I wasn't aware of this feature. This should be relatively simple to check.
  3. Completely forgot to add this. I'll make this change also.

@andrew-platt
Copy link
Collaborator Author

andrew-platt commented Jan 11, 2024

Updated with the above suggestions: the new logic allows for smaller high-res grids (no warnings). Also added a check to make sure the PropagationDir from InflowWind is 0, +/-90, or 180.

New error messages (shifted high-res in both Y and Z for test):
Screenshot 2024-01-10 at 5 08 15 PM

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, but here are a few suggested corrections...

modules/awae/src/AWAE.f90 Outdated Show resolved Hide resolved
modules/awae/src/AWAE.f90 Outdated Show resolved Hide resolved
modules/awae/src/AWAE.f90 Outdated Show resolved Hide resolved
@abhineet-gupta
Copy link

The error message gets triggered for my case which is helpful.
One possible improvement we could make is to add the turbine number in the messages too.
Perhaps something like:

 Try setting:
     Y0_high = 90
     dY_High = 5
 for turine # 1

@andrew-platt
Copy link
Collaborator Author

@abhineet-gupta, good suggestion. The turbine number is listed just above the suggested grid change, but may not be obvious. I made this change.

@andrew-platt andrew-platt merged commit 2e4628f into OpenFAST:rc-3.5.2 Jan 16, 2024
19 checks passed
@andrew-platt andrew-platt deleted the b/FF_HighResAlignment_Y branch January 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants