-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWAE: Mod_AmbWind=3 add error if HR grid not centered on turbine in Y dimension #1963
AWAE: Mod_AmbWind=3 add error if HR grid not centered on turbine in Y dimension #1963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this logic makes sense to me. But I do have a few concerns:
- With this change, we wont allow the case where the high-res domain is a subset of the TurbSim domain. I'm not sure the user would ever want to do this, but this functionality was possible before this change.
- This change forces wind to always propagate along X. The FAST.Farm documentation also suggests that you could propagate wind along Y (by setting PropagationDir in InflowWind to +/-90deg), although I'm not sure anyone ever does this in practice.
- Is there a reason why the Z boundary is not checked in addition to Y?
Good thoughts.
|
Also allow for wind along Y direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, but here are a few suggested corrections...
The error message gets triggered for my case which is helpful.
|
@abhineet-gupta, good suggestion. The turbine number is listed just above the suggested grid change, but may not be obvious. I made this change. |
This is ready to merge.
Feature or improvement description
When the boundaries for InflowWind interpolation were tightened to end at the edge of the grid with version 3.5.0, this had the unintended consequence of not allowing a small shift of the turbine from the exact center of the high-resolution grid. Previously extrapolation of the wind data outside the grid in the +/-Y direction of up to one step was permitted which allowed the turbine to be slightly offset for
Mod_AmbWind=3
cases. However, this is in direct conflict with our modeling guidance forMod_AmbWind=3
cases; our guidance indicates the high resolution grid must exactly match the InflowWind grid.The following diagram illustrates what the issue is:
Figure: FAST.Farm high res grid and OpenFAST wind grid (
Mod_AmbWind=3
) in v3.5.x. This is the case where the grid sizing and spacing for the InflowWind grid and high-res grid are identical, but the turbine is slightly offset. The InflowWind grid is always centered about the turbine and therefore does not line up with the high-resolution grid. This effectively moves points in the high-resolution grid outside the available interpolation boundary for the InflowWind wind field.So to increase usability, we will leave the stricter boundaries in the InflowWind grid interpolation. To make it possible for an end user to figure out what failed, we add an error message indicating what exactly failed and how to fix it. Example error message:
Related issue, if one exists
#1951
https://forums.nrel.gov/t/gf-wind-array-boundaries-violated-grid-too-small-in-y-direction/6149/5
Impacted areas of the software
FAST.Farm usability is somewhat enhanced for
Mod_AmbWind=3
cases.Additional supporting information
There had been multiple reports of issues with
Mod_AmbWind = 3
when a turbine was not aligned exactly with the center of high-resolution grid in the Y direction.Test results, if applicable
N/A