Handling of Paths for SrvD UserSubs Input Files #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
force-pushed
the
f/SrvD_UserSubs_path
branch
from
ebe865e to
f2ab5bc
Compare
@rdamiani pointed out in issue OpenFAST#2059 that the existing method for handling file paths with `UserSubs` is difficult as it requires putting all the user input files in the same location as the ServoDyn file. This commit is from recomendations from @rdamiani for a method he has had good success with. Co-authored-by:rdamiani <r.damiani@RRDengineering.com>
andrew-platt
force-pushed
the
f/SrvD_UserSubs_path
branch
from
f2ab5bc to
c6f9788
Compare
deslaughter
approved these changes
Mar 8, 2024
bjonkman
reviewed
Mar 11, 2024
| @@ -439,6 +439,7 @@ typedef ^ ParameterType IntKi StCCmode - - - "Structural control control mode {0 | |||
| typedef ^ ParameterType IntKi NumOuts - - - "Number of parameters in the output list (number of outputs requested)" - | |||
| typedef ^ ParameterType IntKi NumOuts_DLL - - - "Number of logging channels output from the DLL (set at initialization)" - | |||
| typedef ^ ParameterType CHARACTER(1024) RootName - - - "RootName for writing output files" - | |||
| typedef ^ ParameterType CHARACTER(1024) PriPath - - - "Path of the primary SD input file " - | |||
There was a problem hiding this comment.
SD is SubDyn, so this should be changed to SrvD.
There was a problem hiding this comment.
Corrected directly on rc-3.5.3 with commit 7a2c43e
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Mar 11, 2024
andrew-platt
added a commit
that referenced
this pull request
Apr 11, 2024
Summary of all PR's included in this merge (PR #2121): * Add 4 linearization regression tests * Upgrade to setup-python@v5 and cache@v4 for GH actions * Update fast_linearization_file.py to use less memory * Use env var to set CTest parallel runs, reduce to 2 * Use more efficient method to compare linearization matrices in regression tests. * Fix printing bug in Python Linear Regression test script * GH actions: upgrade upload-artifact to v4 * Fix bug in HD_Perturb_x where SS_Exctn%numStates was used instead of SS_Rdtn%numStates * GH actions: upgrade checkout to v4 and setup-python to v5 * Remove typo in warning, retains c/con option for output flags for backwards compatibility * Bathymetry grid bug and slope normal vector bug fix * Change input string size for bathgrid and waterkin * Lin tests: increase out precision, error printing full filename * Add SubDyn Linearization test case * Lin: incorrect BD index in dUdy for AD motion * Lin: sum BD blade root motion to hub moment m_ud term (consistent with documentation) * Fix bug in BD linearization resulting from reference rotation change * Improve handling of Paths for SrvD UserSubs Input Files * Revert " Resolve BeamDyn initial strain for rotated blade" * BeamDyn: Disable changing the reference frame * BeamDyn: Implement new initial strain fix based on OpenTurbine documentation * SrvD: fix typo in registry from PR #2079 * BeamDyn: Restore previous fix to pitch actuator logic in SetParameters * FASTlib: Turbine(:) array must use Fortran index 1 start * FASTlib: change ExternInitData%TurbineID to %TurbIDforName * FASTlib: change iTurb inputs to routines with c-bindings to index 0 * Set 5MW_Land_DLL_WTurb_cpp as a CPP_API test, not CPP_DRIVER * Adjust if statements in FAST_OpFM_Step for iTurb being in range 1:NumTurbines. * CPP testing: fix logic setting exec name in CMakeList.txt * TurbSim: increase filename to 1024 characters * VSbuild: always build Registry as release x64 * Add initialization of MHK, WtrDpth, MSL2SWL in IfW_InitInp for AWAE module * Use of potentially unallocated array in AeroDyn_AllBldNdOuts. * VSbuild: increase stack size for FAST.Farm * CMake: openmp optional for FF and CPP if not explicitly requested (#2120) * Update docs for release 3.5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
In Issue #2059, @rdamiani pointed out that the existing method for handling file paths with
UserSubsis difficult as it requires putting all the user input files in the same location as the ServoDyn file. This PR gives a method that from @rdamiani for a method he has had good success with.This PR is entirely @rdamini's work merely copied into a PR by me.
Co-authored-by:rdamiani r.damiani@RRDengineering.com
Related issue, if one exists
Closes #2059
Impacted areas of the software
ServoDyn controls where the
UserSubsoption is used (PCMode,VSContrl,HSSBrMode, orYCMode=3).Additional supporting information
The usage of the affected routines is a very specialized case that we don't directly support, but certainly want to make life easier for users of these features.
Test results, if applicable
None.