Support cross-compiling with Mingw #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to cross-compile with mingw on a case-sensitive file-system, the windows.h include must be lowercase
deslaughter
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
I think this change makes sense and is supported by https://stackoverflow.com/questions/15466613/lowercase-windows-h-and-uppercase-windows-h-difference.
|
@deslaughter, should we include this in 3.5.3? |
|
I think that’s a good idea.
…On Fri, Mar 15, 2024 at 12:38 PM Andy Platt ***@***.***> wrote:
@deslaughter <https://github.com/deslaughter>, should we include this in
3.5.3?
—
Reply to this email directly, view it on GitHub
<#2094 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCSATIZ4J3IRMNF62UYEOLYYMPZ7AVCNFSM6AAAAABEX36CXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBQGAZTSOJXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Support cross-compiling openfast in Linux (to build a Windows version)
I'm using Mingw compiler on Linux to cross-compile openfast and build a Windows version (yes, geek but useful for me ...)
Unfortunately the mingw windows header file is "windows.h". In a case-sensitive system (like linux) the build fails in this line, as it's trying to include the header "Windows.h" ('W' upper-case)
Changing the include line to
#include <windows.h>solves my problem and I'm able to cross-compile openfast. The change should not affect the windows native build, as this is a case-insensitive system.Related issue, if one exists
None
Impacted areas of the software
None
Additional supporting information
Test results, if applicable