Remove linking of implicit Fortran libraries #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deslaughter, let's merge this to 3.5.3, then to dev from there. |
deslaughter
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I think this should be removed if it's causing linker issues with other software. I'm pretty sure that I added this to resolve an issue with building the Simulink library, but that's being test by Github Actions and appears to be working, so it seems these libraries are no longer needed.
I agree with @andrew-platt that this should be merged into the rc-3.5.3 branch first, and then into dev
|
Switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes problems when linking to OpenFAST downstream as it adds numerous
-larguments when linking to OpenFAST which are unable to resolve. Using-lis prone to issues in general. It does not appear to be necessary, unless someone can explain why it's necessary and how a project should robustly handle the effects of this downstream.