MD: replace "save" variable with logical in MD_Point #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comments on PR OpenFAST#2214 for details
bjonkman
reviewed
Sep 3, 2024
|
|
||
| END IF | ||
|
|
||
| END DO | ||
|
|
||
| IF (found == 0) THEN ! detect if line not found TODO: fix this, its wrong. If pointNnattached is oprginally 2, then it will be 1 after one run of the loop and l will also be 1 | ||
| IF (found) THEN ! detect if line not found TODO: fix this, its wrong. If pointNnattached is oprginally 2, then it will be 1 after one run of the loop and l will also be 1 |
There was a problem hiding this comment.
wouldn't this need to be if (.not. found)?
There was a problem hiding this comment.
Doh! whoops... I'll get that fixed.
There was a problem hiding this comment.
PR #2403 fixes this
Not sure how to include a facepalm emoji, but this mistake deserves one...
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Sep 3, 2024
andrew-platt
added a commit
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments on PR #2214 for details
Feature or improvement description
PR #2214 accidentally introduce a "save" variable that is persistent between calls to a routine in the
MoorDyn_Point.f90source.Related issue, if one exists
#2214
Impacted areas of the software
MoorDyn
Additional supporting information
We don't allow "save" variables in the code for portability and parrallelization reasons.
Test results, if applicable
No changes