Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.5.4 to dev #2494

Merged
merged 30 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
75f1e32
Fix docs -- fails on rtd
andrew-platt Jul 19, 2024
0e7774a
Add !$ OMP critical around file opening for VTK
andrew-platt Jul 19, 2024
44ff26d
Merge pull request #2340 from andrew-platt/b/OpenMP_FF_vtk_read_Opt2
andrew-platt Jul 19, 2024
97e0f5b
:pencil: Fixed typo in docs/source/install/index.rst
Gjacquenot Aug 10, 2024
43d3d2c
Merge pull request #2366 from Gjacquenot/patch-1
andrew-platt Aug 12, 2024
ff67ad4
FileInfoType: increase line length allowed
andrew-platt Aug 23, 2024
d6e3148
Merge pull request #2389 from andrew-platt/f/WideLinesFileInfoType
andrew-platt Aug 23, 2024
d97ee66
HD bug fix: prevent array index out-of-bound error in HDOut_MapOutput…
luwang00 Aug 28, 2024
cca59dc
Merge pull request #2397 from luwang00/b/HD_PFBdy_Output
andrew-platt Aug 29, 2024
6253e3e
BeamDyn, ModMesh, NWTC_Num performance improvements
deslaughter Aug 16, 2024
c8b9848
Fix bug in BeamDyn performance commit
deslaughter Aug 19, 2024
1d313c9
Fix beamdyn_utest incorrect size of m%qp%upp
deslaughter Aug 20, 2024
48a9e87
Fix more bugs in BeamDyn performance improvements
deslaughter Aug 22, 2024
f93ef05
Modfy executeOpenfastLinearRegressionCase.py to skip comparison of nu…
deslaughter Aug 29, 2024
63c9d3b
Revert "Modfy executeOpenfastLinearRegressionCase.py to skip comparis…
deslaughter Sep 18, 2024
56a97f6
Perturb BD rotation states in WM parameters
deslaughter Sep 18, 2024
68423c3
BeamDyn: fix formatting in test_tools.F90
deslaughter Sep 20, 2024
11f1cd3
Update r-test pointer
deslaughter Sep 20, 2024
e1d3cdb
BD: change to LAPACK_GEMM, add note on ignored error handling
andrew-platt Sep 20, 2024
e28e1a0
Merge pull request #2399 from deslaughter/f/bd-perf
andrew-platt Sep 20, 2024
dde75b8
Intel builds: add /heap-arrays:1000 compile flag
andrew-platt Oct 8, 2024
31d281e
Add /heap-arrays:1000 to cmake intel builds
andrew-platt Oct 8, 2024
69f8dff
Merge pull request #2452 from andrew-platt/b/FF_stackOverflow
andrew-platt Oct 21, 2024
a2e0381
Add changelog for 3.5.4
andrew-platt Oct 21, 2024
05a16b2
Update version info in conf.py
andrew-platt Oct 21, 2024
ea16750
Correction to changelog v3.5.4.md
andrew-platt Oct 21, 2024
efad7a3
Missing PRs and Typo in v3.5.4.md
andrew-platt Oct 24, 2024
8136967
Update r-test pointer for 3.5.4
andrew-platt Oct 28, 2024
6a63db7
Merge pull request #2474 from OpenFAST/rc-3.5.4
andrew-platt Oct 29, 2024
9c395b7
Merge remote-tracking branch 'OpenFAST/main' into m/3.5.4_to_dev
andrew-platt Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmake/OpenfastFortranOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ endmacro(set_fast_intel_fortran)
# arch
#
macro(set_fast_intel_fortran_posix)
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fpic -fpp")
# Set size where temporary are stored on heap instead of stack
# 1000: size in kB (1 MB)
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fpic -fpp -heap-arrays 1000")

# debug flags
if(CMAKE_BUILD_TYPE MATCHES Debug)
Expand Down Expand Up @@ -201,7 +203,9 @@ macro(set_fast_intel_fortran_windows)
# Turn off specific warnings
# - 5199: too many continuation lines
# - 5268: 132 column limit
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} /Qdiag-disable:5199,5268 /fpp")
# Set size where temporary are stored on heap instead of stack
# 1000: size in kB (1 MB)
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} /Qdiag-disable:5199,5268 /fpp /heap-arrays:1000")

# If double precision, make constants double precision
if (DOUBLE_PRECISION)
Expand Down
96 changes: 96 additions & 0 deletions docs/changelogs/v3.5.4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
**Feature or improvement description**
Pull request to merge `rc-3.5.4` into `main` and create a tagged release for v3.5.4.

See the milestone and project pages for additional information

https://github.com/OpenFAST/openfast/milestone/14

Test results, if applicable
See GitHub Actions

### Release checklist:
- [ ] Update the documentation version in docs/conf.py
- [ ] Update the versions in docs/source/user/api_change.rst
- [ ] Verify readthedocs builds correctly
- [ ] Create a tag in OpenFAST
- [ ] Create a merge commit in r-test and add a corresponding annotated tag
- [ ] Compile executables for Windows builds
- [ ] AeroDyn_Driver_x64.exe
- [ ] AeroDyn_Driver_x64_OpenMP.exe
- [ ] AeroDyn_Inflow_C_Binding_x64.dll
- [ ] AeroDyn_Inflow_C_Binding_x64_OpenMP.dll
- [ ] BeamDyn_Driver_x64.exe
- [ ] DISCON.dll (x64)
- [ ] DISCON_ITIBarge.dll (x64)
- [ ] DISCON_OC3Hywind.dll (x64)
- [ ] DISCON_SC.dll (x64)
- [ ] FAST.Farm_x64.exe
- [ ] FAST.Farm_x64_OMP.exe
- [ ] FAST_SFunc.mexw64
- [ ] HydroDynDriver_x64.exe
- [ ] HydroDyn_C_Binding_x64.dll
- [ ] IfW_C_Binding_x64.dll
- [ ] InflowWind_Driver_x64.exe
- [ ] InflowWind_Driver_x64_OpenMP.exe
- [ ] MoorDyn_Driver_x64.exe
- [ ] MoorDyn_C_Binding_x64.dll
- [ ] OpenFAST-Simulink_x64.dll
- [ ] openfast_x64.exe
- [ ] Turbsim_x64.exe

# Changelog

## Overview

This release includes performance improvements for BeamDyn (up to 30% speed increase), python file readers and writers from WEIS, and a fix for stack overflows with FAST.Farm (Intel compilation). A few other minor updates are included as outlined below.

Anyone using BeamDyn will want to update to this version.


## General

### Build systems

#2311 Always build `openfastcpplib` as shared. Use `BUILD_OPENFAST_CPP_DRIVER` to disable `openfastcpp` executable (@deslaughter)
#2173 Fix crash in `MAP_End` when using Intel's new icx compiler and disable caching in setup-python GH action (@deslaughter)


### Python file readers/writers

#2188 Add WEIS file readers and writers (@cortadocodes and @mayankchetan)


## Solvers

### FAST.Farm

#2452 Fix for some stack overflow issues with FAST.Farm when copying large amounts of wind data (closes #2053) (@andrew-platt)
#2340 Add `!$ OMP critical` around file opening for VTK to prevent file collision (@andrew-platt)


## Module changes

### BeamDyn

#2399 BeamDyn performance improvements (@deslaughter)


### ElastoDyn

#2321 Backport of #2317: Explicitly initialize `ED` `RtHS` to zero -- corrects issue with inccorect linearization results (@andrew-platt)


### HydroDyn
#2397 HD bug fix: prevent array index out-of-bound error in `HDOut_MapOutputs` when more than 9 potential-flow bodies are present (@luwang00)

### NWTC-Library
#2389 FileInfoType: increase line length allowed (@andrew-platt)

## Input file changes

No input files change with this release, as this only includes minor bugfixes.

Full list of changes: https://openfast.readthedocs.io/en/main/source/user/api_change.html

Full input file sets: https://github.com/OpenFAST/r-test/tree/v3.5.4 (example input files from the regression testing)

2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def runDoxygen(sourcfile, doxyfileIn, doxyfileOut):
# The short X.Y version.
version = u'3.5'
# The full version, including alpha/beta/rc tags.
release = u'v3.5.3'
release = u'v3.5.4'

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
Expand Down
2 changes: 1 addition & 1 deletion docs/source/install/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ containing the executables, and running a simple test command:

Running OpenFAST with docker
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
OpenFAST is avilable to be run on docker starting with version 3.5.3. Three approaches are shared below.
OpenFAST is available to be run on docker starting with version 3.5.3. Three approaches are shared below.

Using a docker image from Docker hub
------------------------------------
Expand Down
6 changes: 5 additions & 1 deletion docs/source/user/api_change.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Thus, be sure to implement each in order so that subsequent line numbers are cor



OpenFAST v3.5.3 to OpenFAST dev
OpenFAST v3.5.4 to OpenFAST dev
----------------------------------

The HydroDyn module was split into HydroDyn and SeaState. This results in a
Expand Down Expand Up @@ -106,6 +106,10 @@ Old inputs Corresponding new inputs



OpenFAST v3.5.3 to OpenFAST v3.5.4
----------------------------------

No input file changes were made.


OpenFAST v3.5.2 to OpenFAST v3.5.3
Expand Down
Loading
Loading