Create BUILD_OPENFAST_LIB_DRIVER flag for the OpenFAST C++ Library Interface (not CFD) #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AMR-Wind/Nalu-Wind)
…openfast-cpp from the OpenFAST library C++ driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR better separates the
openfastcppexecutable andopenfast_cpp_driverexecutable by renamingopenfast_cpp_drivertoopenfast_lib_driverand adding a specific flag for building it. Theopenfast_lib_driveris an executable used to test a basic C++ library interface toopenfastlib. This library is not the one used for coupling to Nalu-Wind or AMR-Wind. Inv3.5.4, both of these drivers shared the same build flag, which caused issues on some platforms. So this PR gives each one a separate build flag and changes the name of the library based executable to make it more distinct.Impacted areas of the software
CMakeLists.txt files and CI script.