Added TurbSim to OpenFAST #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@1 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
Note: 64bit executable is not updated! Bug fixes: (1) If you ask for .bts, .wnd and .twr files all at the same time, the .wnd file is now generated. (2) The direction in the .hh files is now specified as AeroDyn expects it. (3) The intrinsic random number generator does not assume that 2 seeds is standard (it should run with gfortran now). git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@2 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
I updated the format strings in a couple of subroutines. They contained extra commas, which newer compilers don't like.
I replaced READ(UI,'') statements with calls to ReadCom() in the NWTC Subroutine Library to avoid ungraceful crashing
when the input file is too small.
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@3 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
Minor update to readBLgrid.m in the trunk and to the change log in the PeriodicOutput branch. git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@6 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@19 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
-> merged L. Kilcher's hydro branch, with these modifications: -fixed minor details with certtest input files -updated version number (removed alpha version) -ran certtest and updated TstFiles -updated TurbSim.pdf (pictures saved strangely, fixed with "compress" option in Word) git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@20 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
I replaced the hardcoded "\" file path separator with the variable PathSep from the NWTC Subroutine Library. The previous method prevented the CTS files from being generated on Linux/Mac. (Note there may still be a problem *reading* them in InflowWind.) Problem reported via email from Jens Bay Madsen <jbm@regndata.dk> on 6-Oct-2012. git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@22 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
… by Andy Clifton) git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@23 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@24 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@25 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…TIDAL.inp file. I fixed ArcFiles.txt to include it (also updating update_web.bat page to accept the "update_web -nofiles" syntax). git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@26 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…ng an array with (:,:), so it needs to be in an interface block). + I modified the version number + At the request of a user, I updated some wording on the description of f_max in the user's guide. git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@36 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@46 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
reran certtest and updated results added "large" input file tests (not distributed with code) git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@47 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@49 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…, but I'm going to overhaul the code to make it easier to read and hopefully be able to debug this easier later. git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@53 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…ated by entering UsableTime as "ALL" git-svn-id: https://windsvn2.nrel.gov/TurbSim/trunk@55 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…ly allowing us create dll that exports many/most routines so pyTurbSim can use them. git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@56 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ started restructuring code git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@57 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…nce model is being used. This takes the place of comparing strings each time (and remembering to take TRIM() where appropriate). Hopefully it will be easier to maintain. + for consistency, modified names of routines that calculate velocity spectra; also added doxygen-style documentation for those routines. + separated log profile into it's own routine git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@58 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@59 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ added some very basic error handling (needs work) + removed some unused variables + removed ReadLIVar, which means if people are using T/F for integers it may no longer work. (I think it is a severe error, not fatal.) git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@60 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ replaced FFTMod with code from HydroDyn 2.1 (no global data) git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@63 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@64 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ moved more global variables from module into types + renamed NTot to NPoints git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@65 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ updated IECKAI and IECVKM models so that they use pre-calculated integral scales and standard deviations. Otherwise the values get calculated multiple times, and it's hard to debug git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@66 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ separated velocity profile and direction profile routines git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@67 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
+ changed TWR output files: (1) if both WND and BTS files are requested, TWR will be output (previously wasn't; was only contained in BTS). (2) if TWR is requested but neither WND or BTS are requested, BTS will also be generated. git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@68 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…brary/branches/NetLIb repository + renamed H_Ref to RefHt and U_Ref to URef to correspond (again) to variable names in TurbSim user's Guide. Renamed some local variables so they were no longer called RefHt or URef. + created new routine to output input file info to the summary file (previously was interspersed in GetInput) [did this to modify input file reading in near future] + removed some unnecessary info from the debug file. it's printed to the summary file, so I'm not sure why it needs to be output in the debug file. git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@69 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…h DLL later anyway)
+ added p_met and moved several variables into it
+ split Coh2Coeffs() into
{Coh2H or EyeCoh2H} & H2Coeffs so we don't put the IF statement inside the do loop. didn't change this in the API coherence routine
git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@70 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…ov/forum/wind/viewtopic.php?f=4&t=1547#p7076 (unstable log profile had wrong sign for PsiM) + removed manifest file from VS project + added warning when user-time-series profile has only one point (because wind profile will default to power-law, and wind direction will be 0 [not value calculated from time series] unless otherwise specified by user) git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@131 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
* added comments in ExampleFiles/*.inp to indicate URef should be the 1-hr mean wind speed at 10 meters when using API model * removed Kaimal reference that got copied to API lines * updated CalcFourierCoeffs_API and Spec_API to read more like the equations that they are supposed to implement * added some validations for inputs to API model git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@132 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@133 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
…id inputs. git-svn-id: https://windsvn2.nrel.gov/TurbSim/branches/Modularization@136 c49df35f-aca6-4ea5-bb27-7fcdbeda79b9
added gitignore, readme, and placeholder for bin directory. Fixed comment in a matlab script.
updated compiling documents accordingly
instead of taking value to the -0.75 power (**), it was multiplying by 0.75 (*). Looks like I introduced this in 6-Jun-2016
…intaining history
adds cmake to turbsim; adds turbsim to openfast
|
@ghaymanNREL @rafaelmudafort is anyone taking the task of generating the cmake files? |
|
@michaelasprague the last four commits in this pull request took care of that |
|
@ghaymanNREL @jjonkman are there any remaining concerns with this pull request? |
|
ghayman-nrel [11:57 AM] |
ghost
closed this
ghost
reopened this
jjonkman
reviewed
Sep 14, 2017
There was a problem hiding this comment.
It looks like TurbSim has been merged correctly. I compiled in Visual Studio and was able to identically reproduce the results from Kaimal_15 test. The only issue I see is that there is no TurbSim version number in the header, not even the OpenFAST version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: We still need to generate cmake-related files to build turbsim. The vs-build folder does contain a visual studio project to build turbsim.