Fix crash due to unnecessary settime on Android phone #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug is already fixed in the next version of the official FTC SDK, and therefore it will be fixed in the next version of OpenRC-Turbo as well. Thanks for the contribution though! |
|
Cool. Thx! Looking forward to the new SDK release. |
|
Just for the sake of education, I believe this PR would still crash if the RC and DS phones had clocks more than a second off, so that's not a very sound fix. The way we fixed the crash in the official SDK is to only attempt to set the clock and timezone on a Control Hub, which is the only place it ever worked anyway. |
|
SDK issue of interest: FIRST-Tech-Challenge/FtcRobotController#119 |
|
Yes, the RC app isn't a system one so it's not allowed to set it. Thx for providing more details! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Android phone is used, both of RC and DS might have already adjusted their time correctly from network. It's not necessary to change it. Furthermore, the latest version of Android doesn't allow this operation without system privileged.