-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@QueryMap doesn't work with inheritance #927
Labels
Comments
Thanks for bringing this up. If I recall, this is by design, as Feign's support for bean properties is intentionally simple. This would be an enhancement for us. So I've marked this issue as such. If you would like this feature, please feel free to open a PR. |
support inheritance is very important |
mstrYoda
added a commit
to mstrYoda/feign
that referenced
this issue
May 8, 2019
add apache commons lang3 as mvn dependency to get inherited fields of given class change type.getDeclaredFields() to FieldUtils.getAllFieldsList(type) on FieldQueryMapEncoder
kdavisk6
pushed a commit
that referenced
this issue
May 28, 2019
* This pr resolves issue #927 add apache commons lang3 as mvn dependency to get inherited fields of given class change type.getDeclaredFields() to FieldUtils.getAllFieldsList(type) on FieldQueryMapEncoder * format * remove apache common langs dependency add logic for finding fields which comes via inheritance
Resolved via #960 |
velo
pushed a commit
to velo/feign
that referenced
this issue
Jun 30, 2019
) * This pr resolves issue OpenFeign#927 add apache commons lang3 as mvn dependency to get inherited fields of given class change type.getDeclaredFields() to FieldUtils.getAllFieldsList(type) on FieldQueryMapEncoder * format * remove apache common langs dependency add logic for finding fields which comes via inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Hi,
I've raised an issue in spring-cloud-openfeign project related to @SpringQueryMap not working with inheritance.
However, seems like the root cause is in
FieldQueryMapEncoder
of feign-corefeign/core/src/main/java/feign/querymap/FieldQueryMapEncoder.java
Lines 69 to 75 in 10a4ead
It uses
type.getDeclaredFields()
which returns only fields of a class without inherited fields.Thanks
The text was updated successfully, but these errors were encountered: