Fix issuse #1721 Accept-Encoding header is added twice #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it valid to have duplicated headers?! The server would need to combine it anyway right, maybe we should combine them all |
Proxy may ignore one of the duplicated headers, then it is not valid. According to rfc7230 section 3.2.2, mentioned at #2139, combine them to one is better. |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fix issuse #1721 Accept-Encoding header is added twice * format core code
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Fix issuse #1721 Accept-Encoding header is added twice * format core code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issuse #1721 "Accept-Encoding" header is added twice When feign.compression.response.enabled is set to true in configuration, feign adds "Accept-Encoding" header(s) when sending request. Currently, two header fields are added (Accept-Encoding: gzip and Accept-Encoding: deflate).
After fix, "Accept-Encoding" value is "gzip, deflate".