Add custom tags to MicrometerCapability #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Jan 24, 2024
|
|
||
| public MicrometerCapability(MeterRegistry meterRegistry, Map<String, String> tagsMap) { | ||
| List<Tag> tagsList = mapTags(tagsMap); | ||
| meterRegistry.config().commonTags(tagsList); |
There was a problem hiding this comment.
Do you think this would be testable under our current tests?
There was a problem hiding this comment.
@BartekBanachowicz what about this?
There was a problem hiding this comment.
For now, the answer from my side is no. Not because it isn't doable, but because I don't know how to achieve it yet. I'm still digging through existing test classes
Of course, but I'd prefer to do it in a separate issue |
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* #1456 | Add custom tags to MicrometerCapability * Update MicrometerCapability.java license year --------- Co-authored-by: Marvin <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* #1456 | Add custom tags to MicrometerCapability * Update MicrometerCapability.java license year --------- Co-authored-by: Marvin <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new constructors to
MicrometerCapability, so the clients are now able to add custom tags toMeterRegistryfrom the builder level.Two new constructors were added. The first one can take a
List<Tags>:The second one can take a
Map<String, String>of Keys and Values:Closes #1456