-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Postgis JTS #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but break some test
db6f64c
to
bdb94b2
Compare
On it |
bdb94b2
to
a5f79a7
Compare
Note: also trying to convince these guys to switch to your fork infobip/infobip-spring-data-querydsl#101 |
a5f79a7
to
cd6e06a
Compare
pom.xml
Outdated
@@ -96,7 +96,7 @@ | |||
<argLine>-Xms256m -Xmx512m</argLine> | |||
|
|||
<!-- default bytecode version for src/main --> | |||
<main.java.version>11</main.java.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vidakovic I'm not comfortable at this stage on dropping java 11 support.
Any change on using an older version of postgis
to avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, premier support for JDK 11 already ended - I think - in September 2023 and extended support (I think this is only for paying customers) ends in 2 years from now? My argument would be that everything else (read: Spring/Spring Boot) is also moving forward and probably most of the users are not paying for extended JDK support. Just my 2 cents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, maybe I can change on a 7.0 release... but I don't want to break compatibility on 6.x train
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me. Thanks
<dependency> | ||
<groupId>net.postgis</groupId> | ||
<artifactId>postgis-jdbc-jts</artifactId> | ||
<version>2023.1.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vidakovic I'm not comfortable at this stage on dropping java 11 support.
Any change on using an older version of postgis that is 11 compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to see if that exists... I just know that the dependencies referenced originally are quite different (package names changed!). Let me see if I can find a version with the new package names (and features) that is JDK 11 compatible.
Fixes #415