Add asBase64 option in dhis2 get() function
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ...requestConfig, | ||
| }).then(result => { | ||
| console.log(`Retrieved ${resolvedResourceType}`); | ||
| return handleResponse(result, state, callback); | ||
| const response = asBase64 ? { data: encode(result.data) } : result; |
There was a problem hiding this comment.
This sent me on a bit of a rabbit hole. I think it will be really healthy to rebsae dhis2 on unidic and make it much more standardised
josephjclark
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
@mtuchi this looks fine but I haven't tested it. Are you happy for me to release?
|
@josephjclark yeah i am happy for release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
asBase64option inget()function which will convert theresponseTypeoption toarraybufferand when we get the result we convert the result into a base64 encoded stringFixes #884
Details
axios.interceptors.responseto ignorearraybufferresponse typeasBase64option inget()jsdocsforget()options argumentAI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.