-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDR and NIA adjustments #951
Conversation
@taylordowns2000 not in tools please! There is no runtime code in tools. I agree that a general validator seems useful, although I'd probably recommend using json schema (we have a function for that in common, see for reference). But for now, I'd just bake it into the adaptor that needs it and we'll work out how to generalise later. |
@taylordowns2000 we need to fix or skip that failing test before merging Don't feel you need my approval before updating these adaptors btw (unless you're doing something unusual, like digging into |
tools/mock-validator.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to mocks.js file in their respective adaptors
Summary
This PR introduces a mock-validator which is used by
ghana-bdr
andghana-nia
to verify that the request bodies sent to a specific endpoint match the requirements for those systems.I think that the improved mocks for these adaptors are not particularly interesting for you guys. The thing that I'd like your thoughts on is whether or not the mock-validator is in the right place. I can see myself using this type of simple helper for building mock servers a lot.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.