Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs containing self-edges will produce erroneous MLE estimates #37

Closed
jchodera opened this issue Jan 6, 2022 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@jchodera
Copy link
Contributor

jchodera commented Jan 6, 2022

It appears that graphs provided to arsenic.stats.mle can have self-edges (edges that connect to the same node at both ends).

This line assumes that cannot be the case, and will produce biased, incorrect estimates if provided with self-edges.

We should either automatically omit self-edges or raise an exception if they are encountered.

@jchodera jchodera added the bug Something isn't working label Jan 6, 2022
@jchodera jchodera changed the title Remove self-edges Graphs containing self-edges will produce erroneous MLE estimates Jan 8, 2022
jchodera added a commit that referenced this issue Feb 16, 2022
Fix #37: Fix erroneous MLE estimate when self-edges are included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant