-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plotting.py #64
Conversation
Hello @zhang-ivy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-09-12 20:05:59 UTC |
@mikemhenry @ijpulidos Can you review this and help me determine whether this a PR worth merging into the main repo or if I should just merge it into my own fork? Some of the changes I made may be specific to my own needs, though I did try to make the changes as general as possible. Specifically, the following change may be useful for others, but I implemented them only for the case that I'm interested in: plotting DDGs (and not DGs) using plotting.py (and not plotly.py):
Additionally, I didn't want the data labels to overlap, so I use the |
@mikemhenry : What do you think about including |
@zhang-ivy thank you for pointing that out! I'm fine with it, given that |
TODO
|
@mikemhenry : I think I'm done making changes to this! Could you add |
@zhang-ivy yes! I can take care of this later today |
Description
This PR improves plotting functions in plotting.py. It does not alter any functions in plotlying.py
Todos
Notable points that this PR has either accomplished or will accomplish.
dpi
) for controlling the resolution of the plot when savingadjustText
package to adjust data labels so that they are not overlappingQuestions
Status