Skip to content

Commit

Permalink
build: Upgrade sinon package.
Browse files Browse the repository at this point in the history
This also removes PhantomJS as a test environment.

This is part of #1132.
  • Loading branch information
manthey committed Dec 22, 2021
1 parent 8b3946a commit e53d6f5
Show file tree
Hide file tree
Showing 25 changed files with 234 additions and 605 deletions.
8 changes: 4 additions & 4 deletions docs/developers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ information is submitted to `codecov <https://codecov.io/github/OpenGeoscience/g
Headless browser testing
------------------------

Geojs uses `PhantomJS <http://phantomjs.org/>`_ for headless browser
testing of core utilities. Unfortunately because PhantomJS does not
support webgl at this time, so code paths requiring webgl must be either
mocked or run in an environment such as xvfb.
Geojs uses headless Chrome and Firefox for headless browser testing of core
utilities. If the headless mode does not support webgl at this time, code
paths requiring webgl must be either mocked or run in an environment such as
xvfb.

The headless unit tests should be placed in the ``tests/cases/``
directory. All javascript files in this directory will be detected
Expand Down
2 changes: 1 addition & 1 deletion karma-base.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ module.exports = function (config) {
'/built/': '/base/dist/built/'
},
browsers: [
'PhantomJS'
'ChromeHeadlessTouch'
],
customLaunchers: {
ChromeHeadlessTouch: {
Expand Down
4 changes: 2 additions & 2 deletions karma-cov.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* Return URL friendly browser string
*/
function browser(b) {
/* The browser string starts with the basic browser name (Firefox, PhantomJS,
* etc. Split on the first space or dash to isolate this name. */
/* The browser string starts with the basic browser name (Firefox, Chrome,
* etc.). Split on the first space or dash to isolate this name. */
return b.toLowerCase().split(/[ /-]/)[0];
}

Expand Down
Loading

0 comments on commit e53d6f5

Please sign in to comment.