Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up webgl point updates. #1022

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Speed up webgl point updates. #1022

merged 1 commit into from
Sep 26, 2019

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Sep 4, 2019

When only the point style has changed, just update the GL buffers instead of the entire geometry. For the shaders, use a few less varying variables.

@manthey manthey requested a review from aashish24 September 4, 2019 14:36
@manthey manthey force-pushed the webgl-point-improvements branch 2 times, most recently from 0b55622 to 7319b6b Compare September 5, 2019 04:08
@manthey manthey force-pushed the webgl-point-improvements branch from 7319b6b to 3d6472f Compare September 19, 2019 16:31
aashish24
aashish24 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manthey manthey merged commit 9a3f7f8 into master Sep 26, 2019
@manthey manthey deleted the webgl-point-improvements branch September 26, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashish24 aashish24 aashish24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manthey @aashish24