Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the original event data in the action wheel event. #1030

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Expose the original event data in the action wheel event. #1030

merged 1 commit into from
Sep 19, 2019

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Sep 15, 2019

This was intended, but since the event key was used, and that is populated with the event name, it wasn't actually exposed.

Resolves #1024.

@manthey manthey force-pushed the event-data-actionwheel branch from 978585a to 570be29 Compare September 15, 2019 10:53
@manthey manthey mentioned this pull request Sep 16, 2019
Closed
waxlamp
waxlamp approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? Will clients have to substitute event for eventData anywhere?

@manthey
Copy link
Contributor Author

manthey commented Sep 19, 2019

No. This adds eventData. It was using event, but that was being overridden by the name of the event and so using event functionally did nothing.

@manthey manthey force-pushed the event-data-actionwheel branch from 570be29 to 650af7c Compare September 19, 2019 15:07
@manthey
Expose the original event data in the action wheel event.
650af7c 
This was intended, but since the `event` key was used, and that is
populated with the event name, it wasn't actually exposed.
@manthey manthey merged commit 8ce77ce into master Sep 19, 2019
@manthey manthey deleted the event-data-actionwheel branch September 19, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

geo.event.actionwheel doesn't include wheel delta
2 participants
@manthey @waxlamp