Add auto primitiveShape to the webgl point feature. #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
auto-point-primitive
branch
from
771e144 to
ebf95d9
Compare
manthey
force-pushed
the
webgl-point-improvements
branch
from
7319b6b to
3d6472f
Compare
manthey
force-pushed
the
auto-point-primitive
branch
from
ebf95d9 to
c3113a0
Compare
aashish24
reviewed
Sep 26, 2019
src/webgl/pointFeature.js
Outdated
| @@ -222,6 +220,9 @@ var webgl_pointFeature = function (arg) { | |||
| fillVal = fillFunc(item, i) ? 1.0 : 0.0; | |||
| fillOpacityVal = fillOpacityFunc(item, i); | |||
| fillColorVal = fillColorFunc(item, i); | |||
| if (m_primitiveShapeAuto && ((fillVal && fillOpacityVal) || (strokeVal && strokeOpacityVal)) && radiusVal + (strokeVal && strokeOpacityVal ? strokeWidthVal : 0) > maxr) { | |||
There was a problem hiding this comment.
this line is probably too long and need to be split for consistency
There was a problem hiding this comment.
I split it to multiple lines.
manthey
force-pushed
the
auto-point-primitive
branch
from
c3113a0 to
66c2d60
Compare
aashish24
reviewed
Sep 26, 2019
manthey
force-pushed
the
auto-point-primitive
branch
from
caabdc9 to
0003a64
Compare
The new default primitiveShape, `auto`, uses a sprite (a webgl point) if points are smaller than the GPU's maximum point size and a triangle if any are larger. Specific primitive shapes can still be specified, as there are performance reasons for each of them and auto detection has some time cost.
aashish24
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new default primitiveShape,
auto, uses a sprite (a webgl point) if points are smaller than the GPU's maximum point size and a triangle if any are larger. Specific primitive shapes can still be specified, as there are performance reasons for each of them and auto detection has some time cost.