Fix an issue with affine transforms #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affine transforms would be skipped in certain cases where an optimization path was followed. Detect this condition and don't use the simpler optimized path when affine transforms are present.
|
@manthey what is the context here? Did we hit a case that you could mention here? |
|
Brandon discovered that webgl polygons weren't being affected by an affine transform while text features were. The specific problem is that there is a code optimization path for certain transforms to avoid function calls when possible. If a 3d flat array of coordinates is to be transformed, and we know the transforms are "simple", we can pass it through proj4 using a simpler path that is faster. However, when an affine transform is specified, we can't use this simpler path. |
|
Okay makes sense, thanks for the context |
aashish24
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affine transforms would be skipped in certain cases where an optimization path was followed. Detect this condition and don't use the simpler optimized path when affine transforms are present.