feat: Add a grid feature #1082
Merged
feat: Add a grid feature #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manthey build issues - holding review until it passes |
|
It passes locally (and in a docker build environment). I'm not sure what is failing in travis. This is built on top of PR #1079, so if that gets merged, I'll rebase and see if kicking off travis again fixes it. |
manthey
force-pushed
the
grid-feature
branch
2 times, most recently
from
db5554a to
f2bb8a8
Compare
|
@manthey I have started the review process on this PR |
|
I rebased this to use the github actions. |
This refactors the contourFeature to avoid code duplication, as the grid and contour features are nearly the same. Specifically, the contour feature has data values at each vertex of a mesh and the grid feature has data values on the elements of the mesh. The grid feature has solid colors for each mesh element, while the contour feature has interpolated values between the vertices. This adds a small tutorial. This closes #545.
aashish24
approved these changes
Aug 13, 2021
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the contourFeature to avoid code duplication, as the grid and contour features are nearly the same. Specifically, the contour feature has data values at each vertex of a mesh and the grid feature has data values on the elements of the mesh. The grid feature has solid colors for each mesh element, while the contour feature has interpolated values between the vertices.
This adds a small tutorial.
This closes #545.