perf: Speed up hit tests for points and markers #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the range tree returns multiple points or markers that might be within the search area, we were sorting them to maintain a stable response order. Javascript sort defaults to a lexical sort which casts all values to strings, so we had been doing `points.sort((a, b) => a - b)` to do a numerical sort, but this has a lot of function call overhead and probably is casting each value between strings and numeric datatypes. Instead, we do `points = Uint32Array.from(points).sort();` which uses native javascript functions and is much faster.
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the range tree returns multiple points or markers that might be within the search area, we were sorting them to maintain a stable response order. Javascript sort defaults to a lexical sort which casts all values to strings, so we had been doing `points.sort((a, b) => a
to do a numerical sort, but this has a lot of function call overhead and probably is casting each value between strings and numeric datatypes. Instead, we dopoints = Uint32Array.from(points).sort();` which uses native javascript functions and is much faster.