Reduce point clustering flicker. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two different contributing factors: (1) some times zoom rounding caused a flicker. In floating point, 7.99999999 is essentially 8.0, but their floors are different. In general, round zoom values to six places. (2) gratuitous drawing during the zoom event. After reclustering, a point feature draw() call was being made. This is never necessary (at least on current master).
|
This resolves issue #620. |
Current coverage is 82.85% (diff: 100%)@@ master #621 diff @@
==========================================
Files 85 85
Lines 8019 8019
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6642 6644 +2
+ Misses 1377 1375 -2
Partials 0 0
|
jbeezley
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different contributing factors:
(1) some times zoom rounding caused a flicker. In floating point, 7.99999999 is essentially 8.0, but their floors are different. In general, round zoom values to six places.
(2) gratuitous drawing during the zoom event. After reclustering, a point feature draw() call was being made. This is never necessary (at least on current master).