boundsFromZoomAndCenter returned incorrect values. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using any gcs other than the map's gcs, the function performed two conversions on the map center's coordinates which resulted in erroneous results.
|
@jbeezley This was the error that we ran into on the HistomicsTK project getting the image bounds. |
|
Probably yes. I'll have to check to make sure. |
Current coverage is 85.43% (diff: 100%)@@ master #625 diff @@
==========================================
Files 85 85
Lines 8217 8217
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7018 7020 +2
+ Misses 1199 1197 -2
Partials 0 0
|
jbeezley
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any gcs other than the map's gcs, the function performed two conversions on the map center's coordinates which resulted in erroneous results.