Fix issues with setting feature visibility. #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only gl features honored visibility, and then only if they did not consist of secondary features. Visibility now works on all renderers and a concept of dependentFeatures has been added to group visibility for certain features. Some features still probably don't support visibility properly (such as the graphFeature), but that should be left for a different fix.
Current coverage is 86.46% (diff: 100%)@@ master #632 diff @@
==========================================
Files 85 85
Lines 8273 8290 +17
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7149 7168 +19
+ Misses 1124 1122 -2
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only gl features honored visibility, and then only if they did not consist of secondary features. Visibility now works on all renderers and a concept of dependentFeatures has been added to group visibility for certain features. Some features still probably don't support visibility properly (such as the graphFeature), but that should be left for a different fix.