Report where in a quad a point is located. #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a point search is performed on a quad feature, in addition to determining if the point is in a quad, determine where it is within the quad.
Current coverage is 86.54% (diff: 100%)@@ master #635 diff @@
==========================================
Files 85 85
Lines 8328 8340 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7206 7218 +12
Misses 1122 1122
Partials 0 0
|
Merged
aashish24
approved these changes
Oct 27, 2016
| @@ -161,12 +163,27 @@ var quadFeature = function (arg) { | |||
| util.pointInPolygon(coordinate, poly2)) { | |||
| indices.push(quad.idx); | |||
| found.push(data[quad.idx]); | |||
| coordbasis = util.pointTo2DTriangleBasis( | |||
| coordinate, poly1[0], poly1[1], poly1[2]); | |||
| if (!coordbasis || coordbasis.x + coordbasis.y > 1) { | |||
There was a problem hiding this comment.
some extra comments would be useful here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a point search is performed on a quad feature, in addition to determining if the point is in a quad, determine where it is within the quad.