Allow colors to include an alpha value. #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, handle more css color specifications. Currently, nothing takes advantage of a color which has an alpha value (though the pixelmap soon will). It would be nice to be able to use that in addition to opacity styles. Before, we handled colors of the form rgb object, #rrggbb, #rgb, and css color names. This adds parsing of #rrggbbaa, #rgba, rgb(), rgba(), hsl(), hsla(), and 'transparent', conforming that parsing to the css working group's current draft standard (there are other color formats in that draft that are not implemented). It also adds one additional css color name, as per that draft.
Current coverage is 86.52% (diff: 100%)@@ master #636 diff @@
==========================================
Files 85 85
Lines 8290 8325 +35
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7168 7203 +35
Misses 1122 1122
Partials 0 0
|
Merged
aashish24
approved these changes
Oct 27, 2016
| Math.round(rgb.b * 255)).toString(16).slice(1); | ||
| } | ||
| if (rgb.a !== undefined && allowAlpha) { | ||
| value += (256 + Math.round(rgb.a * 255)).toString(16).slice(1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, handle more css color specifications. Currently, nothing takes advantage of a color which has an alpha value (though the pixelmap soon will). It would be nice to be able to use that in addition to opacity styles.
Before, we handled colors of the form rgb object, #rrggbb, #rgb, and css color names. This adds parsing of #rrggbbaa, #rgba, rgb(), rgba(), hsl(), hsla(), and 'transparent', conforming that parsing to the css working group's current draft standard (there are other color formats in that draft that are not implemented). It also adds one additional css color name, as per that draft.