Fix the map jumping at the end of some transitions. #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, when zooming, the map would jump at the end of the transition. This was caused by the zoom level reaching its final value, then a last animation frame firing, and asking to recenter the map when the center was already correct.
|
@aashish24 I think this was the problem you saw zooming with your laptop. |
Current coverage is 86.90% (diff: 100%)@@ master #650 diff @@
==========================================
Files 87 87
Lines 8585 8586 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7461 7462 +1
Misses 1124 1124
Partials 0 0
|
|
@manthey is this what could cause the issue on some systems (like mine)? I will give it a try. |
aashish24
approved these changes
Dec 1, 2016
|
@manthey seems to have fixed the issue! thanks. The code looks reasonable to me. How did you reproduce this bug on your system? |
|
It happens much more rarely using a mouse wheel than you had with your track pad, but I noticed it on rare occasions, added some debug logging, and when it occurred, looked at what happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when zooming, the map would jump at the end of the transition. This was caused by the zoom level reaching its final value, then a last animation frame firing, and asking to recenter the map when the center was already correct.