Make it easier to disable or replace keyboard actions. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If keyboard.actions is specified in the interactor constructor, replace the set of keyboard actions rather than modify it. Otherwise, it is too annoying to disable or replace.
|
@brianhelba As you asked for, and with a test, too. |
brianhelba
approved these changes
Feb 28, 2017
|
@OpenGeoscience/owners Is it possible to cut a bugfix release for this change? That would let me close out a bug in my project's use of GeoJS. |
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 90.63% 90.63% +<.01%
==========================================
Files 84 84
Lines 8723 8725 +2
==========================================
+ Hits 7906 7908 +2
Misses 817 817
Continue to review full report at Codecov.
|
|
@brianhelba Sure, I'll have a release out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If keyboard.actions is specified in the interactor constructor, replace the set of keyboard actions rather than modify it. Otherwise, it is too annoying to disable or replace.