Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawing rectangle annotations on a rotated map. #694

Merged
merged 2 commits into from
May 2, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented May 2, 2017

If you create a rectangle annotation on a rotated map by clicking twice (rather than by clicking and dragging), the rectangle would be aligned to the map, not the screen.

If you create a rectangle annotation on a rotated map by clicking twice (rather than by clicking and dragging), the rectangle would be aligned to the map, not the screen.
@codecov-io
Copy link

codecov-io commented May 2, 2017

Codecov Report

Merging #694 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   95.23%   95.24%   +0.01%     
==========================================
  Files          84       84              
  Lines        8919     8920       +1     
==========================================
+ Hits         8494     8496       +2     
+ Misses        425      424       -1
Impacted Files Coverage Δ
src/annotation.js 100% <100%> (ø) ⬆️
src/gl/vglRenderer.js 92.74% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249701...5d98363. Read the comment docs.

@manthey manthey merged commit 0d5d2f2 into master May 2, 2017
@manthey manthey deleted the fix-rotated-rectangles branch May 2, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants