Several minor improvements. #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When calling a tile url function, use the layer as the context. This would allow, for instance, two layers in different projections to use the same function which could then use this.gcsTileBounds() to determine the extent of the tile correctly for the layer. - Allow getting and setting the animation queue. This allows, for instance, linking two map's animation queues after they have been created. - Allow getting and setting the autoResize flag.
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 95.25% 95.28% +0.03%
==========================================
Files 83 83
Lines 8980 9000 +20
==========================================
+ Hits 8554 8576 +22
+ Misses 426 424 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a tile url function, use the layer as the context.
This would allow, for instance, two layers in different projections to use the same function which could then use
this.gcsTileBounds()to determine the extent of the tile correctly for the layer.Allow getting and setting the animation queue. This allows, for instance, linking two map's animation queues after they have been created.
Allow getting and setting the
autoResizeflag.