Increase options for tile url templates. #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we would translate `{x}` -> tile x, `{y}` -> tile y, `{z}` ->
tile layer, and `{s}` -> one of the subdomains defined in the layer.
This makes these case insensitive, supports an options `$` prefix, and
allows several additional subdomain specifications. Specifically,
`{s:abc}`, `{S:abc}`, `{a-c}`, and `{a,b,c}` are all equivalent. If the
subdomain is in the template string, the layer's subdomain list is
ignored.
When we refactor the documentation for the tileLayer, this information
should be included in the subdomain and template string docs.
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 95.26% 95.29% +0.02%
==========================================
Files 83 83
Lines 9000 9014 +14
==========================================
+ Hits 8574 8590 +16
+ Misses 426 424 -2
Continue to review full report at Codecov.
|
This parses the tile url template once instead of on every tile, then
just does a string substitution per tile. It also handles character
rangers specified in reverse (e.g., `{c-a}` is the same as `{a-c}`).
|
I refactored the code so that the regex and subdomains are only parsed once when the url is set instead of each time a tile is requested. |
aashish24
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would translate
{x}-> tile x,{y}-> tile y,{z}->tile layer, and
{s}-> one of the subdomains defined in the layer.This makes these case insensitive, supports an options
$prefix, andallows several additional subdomain specifications. Specifically,
{s:abc},{S:abc},{a-c}, and{a,b,c}are all equivalent. If thesubdomain is in the template string, the layer's subdomain list is
ignored.
When we refactor the documentation for the tileLayer, this information
should be included in the subdomain and template string docs.