Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promise-based tests to the tutorial tests. #727

Merged
merged 2 commits into from
Aug 4, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Aug 3, 2017

This allows tutorial tests to include promises. This ensure that, for instance, the external WMS server in that example returns a PNG.

Add thumbnail images for tutorials.

manthey added 2 commits August 3, 2017 08:27
This allows tutorial tests to include promises.  This ensure that, for instance, the external WMS server in that example returns a PNG.
Copy link

@matthewma7 matthewma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manthey manthey merged commit 7f8590c into master Aug 4, 2017
@manthey manthey deleted the tutorial-thumbnails-and-tests branch August 4, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants