Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some boilerplate from examples. #733

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Sep 5, 2017

Each example has an example.json file. These previously required a path entry which we always had defaults to the path of the example. This is now set automatically.

If no custom css file is needed, don't bother having an empty css file.

If no custom pug file is needed, default to using the common pug file.

The common files have been flattened into a single directory.

Each example has an example.json file.  These previously required a path entry which we always had defaults to the path of the example.  This is now set automatically.

If no custom css file is needed, don't bother having an empty css file.

If no custom pug file is needed, default to using the common pug file.

The common files have been flattened into a single directory.
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRTM

@manthey manthey merged commit dd53f94 into master Sep 7, 2017
@manthey manthey deleted the simplify-examples branch September 7, 2017 12:05
@manthey manthey mentioned this pull request Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants