Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When doing a pointSearch on polygons, include strokes. #762

Merged
merged 2 commits into from
Jan 19, 2018
Merged

When doing a pointSearch on polygons, include strokes. #762

merged 2 commits into from
Jan 19, 2018

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jan 15, 2018

Prior to this, only the interior of the polygon was considered.

@manthey
When doing a pointSearch on polygons, include strokes.
e28eb3e 
Prior to this, only the interior of the polygon was considered.
@manthey
Copy link
Contributor Author

manthey commented Jan 15, 2018

Note that pointSearch will also find a polygon when the point is located in its interior, even if the fill style is false. If this behavior is undesired, then the caller is expected to prune out the response (or to have used a line feature).

aashish24
aashish24 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks reasonable to me 👍

@manthey manthey merged commit 3d262da into master Jan 19, 2018
@manthey manthey deleted the select-polygon-edges branch January 19, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashish24 aashish24 aashish24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manthey @aashish24