Allow Hammer.js to exist as an npm-installed package #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving "require('hammerjs')", this will look for npm-installed
"hammerjs" packages to link to, in addition to a global "Hammer" variable.
Since "hammerjs" is an npm-optional dependency of GeoJS, if Webpack
rebundles GeoJS in a downstream project, it will be smart enough to elide
any "require('hammerjs')" statements in the built GeoJS. Without this
change, downstream Webpack is not able to elide "require('Hammer')" usages
(since the module name doesn't match the optional dependency name).
|
@OpenGeoscience/developers If / when this is merged, can we get another patch release? |
manthey
approved these changes
Mar 1, 2018
|
@brianhelba I see in the webpack build, that the error thrown by webpack when hammerjs isn't found reports |
|
@manthey I noticed this already, but didn't really care, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving
require('hammerjs'), this will look for npm-installedhammerjspackages to link to, in addition to a globalHammervariable.Since
hammerjsis an npm-optional dependency of GeoJS, if Webpack rebundles GeoJS in a downstream project, it will be smart enough to elide anyrequire('hammerjs')statements in the built GeoJS. Without this change, downstream Webpack is not able to eliderequire('Hammer')usages (since the module name doesn't match the optional dependency name).Fixes #786