Use https for references to openstreetmap.org. #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, all http requests get a 307 response to forward them to the https server. It is more efficient to access the https server directly. OSM has been running https servers for several years now (at least since 2014), so this should be as stable as OSM is in general. I haven't figured out how to proxy https requests to karma. Perhaps we'd have to run karma in https mode, but my first foray into that didn't work. For now, the one test (the lines example) just uses the http openstreetmap.org reference in the test.
|
awesome.. this is very quick. I am assuming that you addressed the testing issue? |
|
This uses http with a proxy for testing (see PR comment). Also, Chrome 65 headless with mesa has what looks like a bug that caused travis to fail on existing tests, so this PR is dependent on #792. |
aashish24
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, all http requests to openstreetmap.prg get a 307 response to forward them to the https server. It is more efficient to access the https server directly. OSM has been running https servers for several years now (at least since 2014), so this should be as stable as OSM is in general.
I haven't figured out how to proxy https requests to karma. Perhaps we'd have to run karma in https mode, but my first foray into that didn't work. For now, the one test (the lines example) just uses the http openstreetmap.org reference in the test.