Improve setting widget position. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The widget position can be any css-style position, or an x, y coordinate
for the map. If you change the position using the same attributes as
were used previously, it behaved as expected. However, if different
attributes were specified, surprising results could occur.
For instance `widget.position({left: 10, top: 10})` followed by
`widget.position({right: 20, top: 10})`, instead of switching the css
from using `left` to `right`, combined them, so that functionally, the
widget was specifying `{left: 10, right: 20, top: 10}`. Although this
could be avoided by explicitly calling `widget.position({left: null,
right: 20, top: 10})` and could change just one coordinate via call like
`widget.position({top: 11})`, this is surprising behavior.
With this change, setting a widget's position clears the old position
attributes if they are not explicitly set.
aashish24
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The widget position can be any css-style position, or an x, y coordinate for the map. If you change the position using the same attributes as were used previously, it behaved as expected. However, if different attributes were specified, surprising results could occur.
For instance
widget.position({left: 10, top: 10})followed bywidget.position({right: 20, top: 10}), instead of switching the css from usinglefttoright, combined them, so that functionally, the widget was specifying{left: 10, right: 20, top: 10}. Although this could be avoided by explicitly callingwidget.position({left: null, right: 20, top: 10})and could change just one coordinate via call likewidget.position({top: 11}), this is surprising behavior.With this change, setting a widget's position clears the old position attributes if they are not explicitly set.