Only allow pointer events on children of active layers. #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple active layers to work together. Before, the topmost active layer will receive all pointer events. This also fixes an issue in the sceneObject exit function (it should clear the parent, not delete the parent function). This, in turn, required a fix to the annotation test because the test map is destroyed between tests.
|
interesting that we did not catch this before. I am wondering how did you find about this? |
|
@matthewma7 reported this when he created two UI layers. If we have only one UI layer, the issue wasn't obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple active layers to work together. Before, the topmost active layer will receive all pointer events.
This also fixes an issue in the sceneObject exit function (it should clear the parent, not delete the parent function). This, in turn, required a fix to the annotation test because the test map is destroyed between tests.