Add multi color support to continuous color legend #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewma7
commented
Apr 19, 2018
matthewma7
commented
matthewma7
force-pushed
the
multi_color_linear_legend
branch
3 times, most recently
from
df5749a to
ded96ae
Compare
aashish24
reviewed
Apr 20, 2018
tests/cases/colorLegend.js
Outdated
| name: 'Continuous multicolor', | ||
| type: 'continuous', | ||
| scale: 'pow', | ||
| domain: [100, 1000], |
There was a problem hiding this comment.
@matthewma7 we want domain to be piecewise so we should test if this works:
So domain: [100, 500, 1000]
Colors: [red, blue, green]
There was a problem hiding this comment.
The current code doesn't support piecewise function, the workaround is creating multiple color ranges. Do we need piecewise support?
There was a problem hiding this comment.
@matthewma7 I think we want piecewise support in GeoJS. I am assuming that it just request the JavaScript code, the SVG can use the result of the piecewise function.
There was a problem hiding this comment.
I see, I'll add piecewise function support to this PR.
… an option to only show left most and right most axis label
matthewma7
force-pushed
the
multi_color_linear_legend
branch
from
80c6f4a to
cadfa39
Compare
manthey
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.